fix/4397 #4406
Merged
fix/4397 #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elements were resizing incorrectly if they were regenerated while collapsed. Added a check to avoid this issue.
etimberg
requested changes
Jun 22, 2017
src/core/core.controller.js
Outdated
| var newHeight = 0; | ||
|
|
||
| // Avoid issues with the canvas having negative maximum width and/or height due to element being collapsed | ||
| if (Math.floor(helpers.getMaximumWidth(canvas)) >= 0) { |
There was a problem hiding this comment.
I would change just just slightly to cache the return of helpers.getMaximumWidth(canvas) into a local variable. This would improve minification and performance. The max width function reads some styles off the canvas element which can be slow
There was a problem hiding this comment.
Agree, and could be simply:
var newWidth = Math.max(0, Math.floor(helpers.getMaximumWidth(canvas)));
...
src/core/core.controller.js
Outdated
| if (Math.floor(helpers.getMaximumWidth(canvas)) >= 0) { | ||
| newWidth = Math.floor(helpers.getMaximumWidth(canvas)); | ||
| } | ||
| if (helpers.getMaximumHeight(canvas) >= 0) { |
There was a problem hiding this comment.
Same comment here about the return of helpers.getMaximumHeight
etimberg
approved these changes
Jun 23, 2017
simonbrunel
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elements were resizing incorrectly if they were resized while collapsed. Added a check to avoid this issue.