Fix non-passive event listener warning in Chrome #4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
simonbrunel
commented
Jun 25, 2017
src/platforms/platform.dom.js
Outdated
| }()); | ||
|
|
||
| function addEventListener(node, type, listener) { | ||
| if (node.addEventListener) { |
There was a problem hiding this comment.
@etimberg addEventListener and removeEventListener seems supported by IE9+ and all other browsers. What do you think to simplify these methods and remove attach/detachEvent + ['on' + type] =?
There was a problem hiding this comment.
I think we can do that. Our official support is IE >=11
etimberg
approved these changes
Jun 25, 2017
src/platforms/platform.dom.js
Outdated
| }()); | ||
|
|
||
| function addEventListener(node, type, listener) { | ||
| if (node.addEventListener) { |
There was a problem hiding this comment.
I think we can do that. Our official support is IE >=11
simonbrunel
force-pushed
the
helpers-events
branch
from
5c079ff
to
9657401
Compare
Deprecate `addEvent` and `removeEvent`, and move implementation in `platform.dom.js`. Add 'options' feature detection to register event listeners as passive and prevent warning in Chrome.
simonbrunel
force-pushed
the
helpers-events
branch
from
9657401
to
9d8ebcb
Compare
|
Updated: removed old ways to add/remove events. |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
addEventandremoveEvent, and move implementation inplatform.dom.js. Add 'options' feature detection to register event listeners as passive and prevent warning in Chrome.Replaces #4356
Fixes #4287