New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] master branch time scale min/max handling broken #4514
Comments
Did some debugging on this. It was introduced in #4267 I think the issue is coming from https://github.com/chartjs/Chart.js/blob/master/src/helpers/helpers.time.js#L58-L59 but I'm not sure exactly how yet. |
The reason this works with I think a potential solution to this bug is to change line 63 to also include a condition of I also think that line 74 needs to change from |
@andig here's a fork of your fiddle with a custom build of my two proposed changes above: http://jsfiddle.net/dnr07vge/1/ @benmccann @IlyaBeliaev please verify that my potential solution is correct. |
Adding |
|
Also, regarding #4267 the min/max timestamps in the example already are exactly at the month boundary- shouldn't those remain untouched in any case? |
we have an For 4267 I think it's that they were also at the year boundary too which is the major unit which is why it was not seen. |
It seems there is already an associated test but it succeeds: https://github.com/chartjs/Chart.js/blob/master/test/specs/scale.time.tests.js#L303. The min/max is already being modified from what is set to in the options and the test was there before #4267.
It seems So- what is the expected behaviour? |
Looks like the test changed in #4268 2d7c1f0#diff-32e22477b9f6458d20701ea5c8720ea4R300 I think the test needs to go back to the prior value and the code changed so that it passes |
Follow-up to #4493 (comment). http://jsfiddle.net/andig2/6raazty4/3/ has min/max set to 1.7.2016-1.8.2017. The fiddle shows different min/max values when displaying the chart.
Expected behaviour: min/max axis settings are honored.
The text was updated successfully, but these errors were encountered: