Scales: add axis to convertTicksToLabels callback
#4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andig
force-pushed
the
add-axis-reference
branch
from
286ce2d
to
b7ad1da
Compare
|
Updated |
|
The other callbacks are triggered with the |
andig
force-pushed
the
add-axis-reference
branch
from
b7ad1da
to
de9f7fa
Compare
Done, reverted to its earlier implementation. |
etimberg
approved these changes
Aug 11, 2017
silverspectro
pushed a commit
to silverspectro/Chart.js
that referenced
this pull request
Aug 21, 2017
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tick formatting it can be beneficial to have access to the axis. This PR adds the axis as
thisparameter- apparently this is amongst the few callbacks that didn't havethisyet.Note: all other scale events are passing
[this]which is an array ofChartElement. I couldn't figure why the array notation but it might make sense to use the same here instead of the bluntthis.