Fix regression in x-axis interaction mode #4762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
reviewed
Sep 15, 2017
test/specs/core.interaction.tests.js
Outdated
| @@ -192,6 +192,47 @@ describe('Core.Interaction', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('x-axis mode', function() { | |||
There was a problem hiding this comment.
I would move this unit test in global.deprecations.tests.js, under version 2.4.0
test/specs/core.interaction.tests.js
Outdated
| labels: ['Point 1', 'Point 2', 'Point 3'] | ||
| }; | ||
|
|
||
| beforeEach(function() { |
There was a problem hiding this comment.
I think data and acquireChart can go directly in the it( until we need to refactor for another test?
simonbrunel
approved these changes
Sep 16, 2017
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4747