Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] version 2.7.0 is breaking SEMVER specs. #4778

Closed
jorge-autogravity opened this issue Sep 19, 2017 · 7 comments
Closed

[BUG] version 2.7.0 is breaking SEMVER specs. #4778

jorge-autogravity opened this issue Sep 19, 2017 · 7 comments

Comments

@jorge-autogravity
Copy link

According to http://semver.org/ any breaking change is cause of bumping the semver major version. In this case chart.js should be 3.0.0 instead of 2.7.0

That versioning inconsistency broke a feature in my web app last build.

@simonbrunel
Copy link
Member

@jorge-autogravity can you be more explicit about the exact breaking change?

@jorge-autogravity
Copy link
Author

@simonbrunel the breaking change mentioned on https://github.com/chartjs/Chart.js/releases/tag/v2.7.0

@simonbrunel
Copy link
Member

simonbrunel commented Sep 19, 2017

Agree, #4079 should have been postponed until 3.0.0 - really sorry for that. I guess we didn't release it as 3.0.0 because we have lot of pending work that we want to finish until Chart.js 3, so we released 2.7.0 since many people were asking for.

@etimberg should we delay any PR that introduces breaking changes to the next major release? that might become complicated to maintain because PRs will diverge quickly from master. Or maybe should we consider to target a new major version as soon as we want to introduce a breaking change? meaning that we will not support a major version for very long.

@jorge-autogravity you marked this ticket as BUG, what do you suggest?

@jorge-autogravity
Copy link
Author

@simonbrunel I think its too late to revert.. unless you want to publish 2.8.0 reverting the breaking change.
Anyways we locked the version in our end. I don't want to add more work to you. Just wanted to point out an area of improvement.

Thanks for building and maintaining this OSS project. It has been very helpful to me and my team.

@etimberg
Copy link
Member

That breaking change is hard because it essentially reverts back to the v2.0.0 behaviour that changed at a previous minor version.

In general we probably need a v3 release soon so that we can remove a lot of code that maintains backwards compatibility.

@jeff-kilbride
Copy link

jeff-kilbride commented Oct 10, 2017

Also, aspectRatio isn't listed as an option in the docs, even though that's the suggested method for reverting to pre 2.7.0 behavior (unless I'm missing it).

I found an example in the original pull request: #4079 (review)

@etimberg
Copy link
Member

etimberg commented Jan 1, 2020

Closing since this is quite old and not relevant to the current version (2.9.x). The next released version will be v3.0

@etimberg etimberg closed this as completed Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants