Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved rendering of tables describing options #4851

Merged
merged 1 commit into from Oct 16, 2017
Merged

Improved rendering of tables describing options #4851

merged 1 commit into from Oct 16, 2017

Conversation

minusf
Copy link
Contributor

@minusf minusf commented Oct 16, 2017

hopefully a better patch

simonbrunel
simonbrunel approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @minusf. BTW, you didn't need to create a new PR, you could simply push more commit to your branch.

Replaces #4832

@simonbrunel simonbrunel added this to the Version 2.7.1 milestone Oct 16, 2017
@etimberg etimberg merged commit 11315fb into chartjs:master Oct 16, 2017
@benmccann benmccann changed the title minor doc fixes Improved rendering of tables describing options Oct 21, 2017
yofreke pushed a commit to yofreke/Chart.js that referenced this pull request Dec 30, 2017
@minusf @yofreke
minor doc fixes (chartjs#4851)
273cd2a
@snyk-bot snyk-bot mentioned this pull request Mar 9, 2020
Closed
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@minusf @etimberg
minor doc fixes (chartjs#4851)
b26220f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbrunel simonbrunel simonbrunel approved these changes

Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
Version 2.7.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minusf @simonbrunel @etimberg