Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retinaDisplay is overwriting my explicit styling #4872

Closed
andersponders opened this issue Oct 20, 2017 · 2 comments
Closed

retinaDisplay is overwriting my explicit styling #4872

andersponders opened this issue Oct 20, 2017 · 2 comments

Comments

@andersponders
Copy link
Contributor

canvas.style.height = height + 'px';

The comment attached to line says "if they are not set" lets use the render size as the display size but theres no conditional here, its just setting them every time over my existing style options

@Ejdamm
Copy link

Ejdamm commented Oct 26, 2017

This bug makes the usage example broken http://www.chartjs.org/docs/latest/getting-started/usage.html and also here http://www.chartjs.org/docs/latest/
It might scare some new users off when not even the example code works.

@etimberg etimberg added this to the Version 2.8 milestone Nov 22, 2017
@etimberg
Copy link
Member

Done in #4874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants