Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] moment version too restrictive #4903

Closed
sebastianhaeni opened this issue Oct 30, 2017 · 1 comment
Closed

[BUG] moment version too restrictive #4903

sebastianhaeni opened this issue Oct 30, 2017 · 1 comment

Comments

@sebastianhaeni
Copy link

Expected Behavior

The dependency on moment.js should be loosened to something like >=2.18.0 <3.0.0 since minor updates should not break the API of Chart.js.

Current Behavior

The restriction is on ~2.18.0. moment.js was recently updated to 2.19.1.

Context

If we have a dependency on moment.js in our own package.json and Chart.js has it's dependency, the likelihood of us using the same version is small. Deduping is not possible when a different minor version of moment.js is used.

A problem arised because we use webpack in our build process. Webpack bundled the separate version that Chart.js requires in a separate instance and thus didn't use the global locale settings anymore. So the time scales were always in English.

Environment

  • Chart.js version: 2.7.0
@etimberg etimberg added this to the Version 2.8 milestone Oct 30, 2017
@etimberg
Copy link
Member

This was done in #4891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants