Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos and broken links in the documents #5010

Merged
merged 2 commits into from Nov 30, 2017
Merged

Conversation

beiz23
Copy link
Contributor

@beiz23 beiz23 commented Nov 29, 2017

  • Add a link to docs/general/device-pixel-ratio.md in docs/SUMMARY.md, since users could not reach the document on device-pixel-ratio.
  • fix small typos and unresolved anchors.

Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, I would just rename the "Ratio" section to "Pixel Ratio"

docs/SUMMARY.md Outdated
@@ -7,6 +7,7 @@
* [Usage](getting-started/usage.md)
* [General](general/README.md)
* [Responsive](general/responsive.md)
* [Ratio](general/device-pixel-ratio.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call this section "Pixel Ratio" since there is also "Aspect Ratio" detailed in the Responsive section

Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @simonbrunel

Respond to changes request
@beiz23
Copy link
Contributor Author

beiz23 commented Nov 29, 2017

I renamed the "Ratio" section to "Pixel Ratio". Thank you for the quick reviews. 😄

@simonbrunel simonbrunel merged commit 9a7182b into chartjs:master Nov 30, 2017
@simonbrunel
Copy link
Member

Thanks @beiz23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants