Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #5029 - infinite loop due to insufficient bounds checking #5041

Merged
merged 1 commit into from Dec 14, 2017
Merged

Fix issue #5029 - infinite loop due to insufficient bounds checking #5041

merged 1 commit into from Dec 14, 2017

Conversation

jcopperfield
Copy link
Contributor

@jcopperfield jcopperfield commented Dec 14, 2017 •
edited by simonbrunel

While generating the time axis, a negative stepSize will result in an infinite loop.
A negative stepSize could be generated by determineStepSize when the capacity argument is also negative. This PR will have getLabelCapacity always return a positive capacity and clean up a previous check in determineStepSize.

fiddle https://jsfiddle.net/aLk05ptk/10/

Fixes #5029

@jcopperfield
Fix issue chartjs#5029
c4089db 
 - infinite loop in generating time axis, due to insufficient bounds checking.
simonbrunel
simonbrunel approved these changes Dec 14, 2017
View reviewed changes
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcopperfield

@etimberg etimberg merged commit f9beedb into chartjs:master Dec 14, 2017
@etimberg etimberg added this to the Version 2.8 milestone Dec 14, 2017
@jcopperfield jcopperfield deleted the PR-20171214-5029 branch December 14, 2017 17:02
@fanthos fanthos mentioned this pull request Dec 27, 2017
Closed
yofreke pushed a commit to yofreke/Chart.js that referenced this pull request Dec 30, 2017
@jcopperfield @yofreke
Fix issue chartjs#5029 (chartjs#5041)
8973bf4 
- infinite loop in generating time axis, due to insufficient bounds checking.
@snyk-bot snyk-bot mentioned this pull request Mar 9, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@jcopperfield @etimberg
Fix issue chartjs#5029 (chartjs#5041)
99f57be 
- infinite loop in generating time axis, due to insufficient bounds checking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbrunel simonbrunel simonbrunel approved these changes

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 2.7.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcopperfield @simonbrunel @etimberg