Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical gridlines stopped working in 2.7.2 #5315

Closed
karolyi opened this issue Mar 3, 2018 · 3 comments
Closed

Vertical gridlines stopped working in 2.7.2 #5315

karolyi opened this issue Mar 3, 2018 · 3 comments
Milestone

Comments

@karolyi
Copy link

karolyi commented Mar 3, 2018

Expected Behavior

I'm using a bar chart with manually specified grid lines. They should be displayed as it was before 2.7.2.
With 2.7.1 it displays such as:
image

Current Behavior

They stopped working.

Possible Solution

Fix it?

Steps to Reproduce (for bugs)

https://codepen.io/anon/pen/PQgEZx

Environment

  • Chart.js version: 2.7.2(latest)
  • Browser name and version: latest chrome, generally
@simonbrunel simonbrunel added this to the Version 2.8 milestone Mar 3, 2018
@simonbrunel
Copy link
Member

I suspect #5178 to be the cause of this issue (this line), it should be:

var axisWidth = helpers.valueAtIndexOrDefault(me.options.gridLines.lineWidth, ???); // ??? maybe 0?

@jhaenchen what do you think?

@karolyi as a workaround and if you use the same width for all lines, your fiddle works with lineWidth: 1

@karolyi
Copy link
Author

karolyi commented May 19, 2018

bump

@nagix
Copy link
Contributor

nagix commented Dec 2, 2018

This was solved by #5751

@nagix nagix closed this as completed Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants