Restore original styles when removing hover #5570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
hover
branch
4 times, most recently
from
61a472e
to
30380c4
Compare
benmccann
commented
Jun 16, 2018
| @@ -19,7 +19,6 @@ module.exports = function(karma) { | |||
| // These settings deal with browser disconnects. We had seen test flakiness from Firefox | |||
| // [Firefox 56.0.0 (Linux 0.0.0)]: Disconnected (1 times), because no message in 10000 ms. | |||
| // https://github.com/jasmine/jasmine/issues/1327#issuecomment-332939551 | |||
| browserNoActivityTimeout: 60000, | |||
There was a problem hiding this comment.
I removed this line that I had added in an earlier PR because it's very annoying to use with gulp test --watch. It closes the browser after 10 min which makes debugging really hard. Hopefully browserDisconnectTolerance: 3 will be enough. We could make it browserDisconnectTolerance: 5 or something if we want to add a little extra buffer since we're removing browserNoActivityTimeout
etimberg
approved these changes
Jun 25, 2018
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Refactor `updateElement` and `removeHoverStyle` and fix tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@loicbourgois sent #5194 which was closed due to inactivity. This is an updated version of the original PR. I've made just a minor change so that the tests pass
This PR stores the original styles when hovering and then restores them when removing the hover.
This reduces the amount of code used for applying and removing hover styles by a fair amount (though the PR adds a lot of test code, so the overall lines of code don't change much)
This also fixes hovering on the financial charts. You can see that the financial chart samples are broken. Hovering applies a different style, but removing hover does not restore them.