Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 15 minutes time steps #5613

Merged
merged 2 commits into from Jul 7, 2018
Merged

Add 15 minutes time steps #5613

merged 2 commits into from Jul 7, 2018

Conversation

fenichelar
Copy link
Contributor

@fenichelar fenichelar commented Jul 1, 2018 •
edited

Ideally, this should be configurable.

benmccann
benmccann reviewed Jul 3, 2018
View reviewed changes
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, but I would add it to second as well for consistency.

@fenichelar
Copy link
Contributor Author

@benmccann Duh, how did I miss that... Done!

@etimberg etimberg requested a review from simonbrunel July 7, 2018 12:36
@simonbrunel simonbrunel added this to the Version 2.8 milestone Jul 7, 2018
@simonbrunel simonbrunel merged commit 1cd0469 into chartjs:master Jul 7, 2018
@simonbrunel
Copy link
Member

Thanks @fenichelar

@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 9, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@fenichelar @simonbrunel
Add 15 minutes time steps (chartjs#5613)
dd1e15a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

@simonbrunel simonbrunel simonbrunel approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
Version 2.7.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fenichelar @simonbrunel @benmccann