Prevent bezier points from being capped when a data point is off the chart #5937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
reviewed
Dec 28, 2018
benmccann
reviewed
Jan 2, 2019
| var area = me.chart.chartArea; | ||
| var points = (meta.data || []); | ||
| var lineModel = meta.dataset._model; | ||
| var area = chart.chartArea; |
There was a problem hiding this comment.
I might call this chartArea to be a little clearer. And I think model would probably be fine for the previous variable. But I don't feel strongly about either
There was a problem hiding this comment.
model is used to keep point._model later, so this needs to be a different name.
There was a problem hiding this comment.
I prefer area, which I think is clear enough in that context. I also prefer model but as you said it's already taken.
benmccann
previously approved these changes
Jan 2, 2019
etimberg
previously approved these changes
Jan 3, 2019
simonbrunel
requested changes
Jan 4, 2019
| var area = me.chart.chartArea; | ||
| var points = (meta.data || []); | ||
| var lineModel = meta.dataset._model; | ||
| var area = chart.chartArea; |
There was a problem hiding this comment.
I prefer area, which I think is clear enough in that context. I also prefer model but as you said it's already taken.
etimberg
approved these changes
Jan 5, 2019
This was referenced Jan 7, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5265 reported that horizontal lines appear in a chart. When I tried to skip the clipping for lines, I noticed that lines drawn off the chart have bezier control points on the y axis, and some lines overflow into the chart area.
This PR fixes this issue by preventing bezier points from being capped when a data point is off the chart.
Version 2.7.3: https://jsfiddle.net/nagix/e40qgfzs/
Master + This PR: https://jsfiddle.net/nagix/h8dp4ft6/
Fixes #5265