Line scriptable options #5973
Merged
Line scriptable options #5973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates the hover style tests to properly setup the chart
kurkle
reviewed
Jan 10, 2019
nagix
reviewed
Jan 10, 2019
benmccann
reviewed
Jan 10, 2019
benmccann
previously approved these changes
Jan 11, 2019
I agree this because it is a long list and |
nagix
reviewed
Jan 11, 2019
kurkle
previously approved these changes
Jan 11, 2019
|
I quickly split the table into two sections: Point Properties and Line Properties. I will edit the copy again this evening. |
|
@etimberg I would not split the options table which gives a complete overview of all the dataset options but I would split only the styling section ( |
etimberg
force-pushed
the
line-scriptable-options
branch
from
29fe1f2
to
99fcb01
Compare
etimberg
force-pushed
the
line-scriptable-options
branch
from
35fcdfd
to
3bc7970
Compare
nagix
previously approved these changes
Jan 12, 2019
kurkle
previously approved these changes
Jan 12, 2019
simonbrunel
reviewed
Jan 12, 2019
simonbrunel
approved these changes
Jan 12, 2019
nagix
approved these changes
Jan 13, 2019
Merged
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR introduces scriptable configuration options for points on line charts. The user can script the styling and interaction options.
Testing
The existing unit tests covering the setHoverStyle dataset controller method were removed as they did not have proper setup for use with scriptable options.
Fixture based tests were written to test:
pointBackgroundColorpointBorderColorpointBorderWidthpointRadiuspointRotationpointStyleDocumentation
I updated the line chart documentation to match the style of the bubble & bar charts. It may be a good idea to split the
Stylingsection of the documents intoLine StylingandPoint Styling. If there is agreement on that change I can go ahead and make the update.