Add instructions for image-based tests to the contributors guide #6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
reviewed
Feb 17, 2019
benmccann
force-pushed
the
image-tests
branch
from
ac45be1
to
bfc55fa
Compare
etimberg
previously approved these changes
Feb 17, 2019
kurkle
previously approved these changes
Feb 17, 2019
nagix
previously approved these changes
Feb 18, 2019
simonbrunel
reviewed
Feb 20, 2019
simonbrunel
reviewed
Feb 20, 2019
kurkle
reviewed
Feb 21, 2019
kurkle
previously approved these changes
Feb 21, 2019
|
You're right. I just tested and |
|
Hi @benmccann, I was using this updated guide to add an image test for a new feature. This guide was pretty easy to follow. I did have just some minor comments to add to this PR. Hopefully they are helpful. |
Vincent-Ip
reviewed
Feb 22, 2019
Vincent-Ip
reviewed
Feb 22, 2019
|
I thin the |
|
Ok. Added a line about the bug option |
kurkle
previously approved these changes
Feb 24, 2019
nagix
reviewed
Feb 25, 2019
benmccann
force-pushed
the
image-tests
branch
from
04d2566
to
cdb1b9a
Compare
kurkle
approved these changes
Feb 25, 2019
nagix
approved these changes
Feb 25, 2019
simonbrunel
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
Thanks @benmccann, I should have wrote these guidelines long time ago :)
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly borrowed from #3988 along with incorporating some info from recent questions asked in the Slack channel