Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scale fitting logic and performance #6074

Closed
benmccann opened this issue Feb 17, 2019 · 2 comments
Closed

Improve scale fitting logic and performance #6074

benmccann opened this issue Feb 17, 2019 · 2 comments

Comments

@benmccann
Copy link
Contributor

benmccann commented Feb 17, 2019

  • core.layouts calls scale.update multiple times. This is unnecessary. We do not need to calculate the ticks multiple times for example. We should instead call fit rather than update
  • fit, autoSkip, and calculateTickRotation do not work well together
    • There's some trade-off between auto-skipping and label rotation. It's unclear how these relate. Clarification proposed in Improve autoSkip documentation #6079
    • _autoSkip should probably happen in update rather than draw. Right now fit assumes all ticks will be drawn, which isn't true when autoSkip: true
@kurkle
Copy link
Member

kurkle commented Feb 18, 2019

I agree to:

  • fit instead of updated when determining layout
  • _autoSkip (and rotate) in update.

I don't think that auto skipping and auto rotation should be mutually exclusive. because after rotating, there might still be the need to skip.

@benmccann
Copy link
Contributor Author

Closed by #6304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants