Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed #6492

Closed
gotoken opened this issue Sep 1, 2019 · 5 comments · Fixed by #6493
Closed

Build failed #6492

gotoken opened this issue Sep 1, 2019 · 5 comments · Fixed by #6493

Comments

@gotoken
Copy link

gotoken commented Sep 1, 2019

The last three build on travis failed, whereas it looks passed in the build requests page:
https://travis-ci.org/chartjs/Chart.js/requests

These are failed builds:
https://travis-ci.org/chartjs/Chart.js/builds/578433894
https://travis-ci.org/chartjs/Chart.js/builds/579241444
https://travis-ci.org/chartjs/Chart.js/builds/579283705

I found this curious problem because build failed with my local clone after npm cache clear before git pull three days ago. Now also earlier checkout revisions cannot be built successfully.

I worry whether you developers realize this problem and so I report this. If you think this issue is not chart.js matter, please reject and close. Thanks in advance.

@benmccann
Copy link
Contributor

Sigh. There must be some new version of some package that made this start happening. This is not the first time our build has started suddenly failing due to a new version of a dependency (see also #6039). This is frustrating and is exactly what package-lock.json is meant to prevent. We should really start using package-lock.json to prevent these errors in the future

@gotoken
Copy link
Author

gotoken commented Sep 2, 2019

Thank you for the apposite explanation. I've understood the background. Unfortunately I've removed my local yarn-lock.json which builds successfully...

@benmccann
Copy link
Contributor

I've sent #6493 to fix it

@gotoken
Copy link
Author

gotoken commented Sep 3, 2019

Amazing! I had tried fixing rollup.config.json but could not have achieved.

https://travis-ci.org/chartjs/Chart.js/builds/580053231 LGTM. Thank you.

@gotoken gotoken closed this as completed Sep 3, 2019
@gotoken
Copy link
Author

gotoken commented Sep 3, 2019

Oh, I would appreciate if you could merge #6493 into master.

@gotoken gotoken reopened this Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants