Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10x Performance Regression on uPlot Benchmark since v3.0.0-alpha #7448

Closed
etimberg opened this issue May 31, 2020 · 1 comment · Fixed by #7452
Closed

10x Performance Regression on uPlot Benchmark since v3.0.0-alpha #7448

etimberg opened this issue May 31, 2020 · 1 comment · Fixed by #7452
Milestone

Comments

@etimberg
Copy link
Member

etimberg commented May 31, 2020

Expected Behavior

V3 dev should be as fast as V3 alpha

Current Behavior

V3 dev is 10x slower than v3.0.0-alpha

Possible Solution

Steps to Reproduce (for bugs)

v3.0.0-alpha:

var Point =
function (_Element) {
  _inherits(Point, _Element);
  function Point(cfg) {
    var _this;
    _classCallCheck(this, Point);
    _this = _possibleConstructorReturn(this, _getPrototypeOf(Point).call(this));
    _this.options = undefined;
    _this.skip = undefined;
    _this.stop = undefined;
    if (cfg) {
      _extends(_assertThisInitialized(_this), cfg);
    }
    return _this;
  }

master:

var Point = function (_Element) {
  _inherits(Point, _Element);
  var _super = _createSuper(Point);
  function Point(cfg) {
    var _this;
    _classCallCheck(this, Point);
    _this = _super.call(this);
    _this.options = undefined;
    _this.skip = undefined;
    _this.stop = undefined;
    if (cfg) {
      _extends(_assertThisInitialized(_this), cfg);
    }
    return _this;
  }

Environment

@etimberg etimberg added this to the Version 3.0 milestone May 31, 2020
@benmccann
Copy link
Contributor

It sounds like loose is the way to go

The only other options would be:

  • Drop IE11 support
  • Differential bundling - create one bundle without babel for modern evergreen browsers and one with for IE11

Neither of those options sound super appealing to me though compared to loose. We should also be sure to document the loose option in the performance documentation for users who and applying babel themselves to our ES6 bundle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants