Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use options.locale property as default for the date adapters #7859

Closed
stockiNail opened this issue Oct 7, 2020 · 0 comments · Fixed by #10528
Closed

Use options.locale property as default for the date adapters #7859

stockiNail opened this issue Oct 7, 2020 · 0 comments · Fixed by #10528

Comments

@stockiNail
Copy link
Contributor

Feature Proposal

The locale property has been implemented for V3 in order to use it for number formatting on scale.
Nevertheless the locale can be used for dates as well, and then it could set to datefns and luxon date adapters.
I would suggest to use the locale property set at chart (or defaults) options level, as default for the date adapter (if not set on the adapter options).

Feature Use Case

With this feature, a developer can set the locale only once (in chart.options.locale or defaults.locale) instead of replicate it in several options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants