Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using version 2.9.3 gets Maximum call stack size exceeded exception in google chrome. #7881

Closed
davidspencerward opened this issue Oct 13, 2020 · 5 comments · Fixed by #7906
Closed

Using version 2.9.3 gets Maximum call stack size exceeded exception in google chrome. #7881

davidspencerward opened this issue Oct 13, 2020 · 5 comments · Fixed by #7906
Labels
type: bug version: 2

Comments

@davidspencerward
Copy link

I am using chartjs to create a scatter chart of OOM events by timestamp. If I use version 2.9.3, I get the "Maximum call stack size exceeded" exception in google chrome. Same for versions 2.9.0, 2.9.1 and 2.9.2. But version 2.8.0 works fine. I will paste in my HTML/JS code. To get the error, just change "2.8.0" to "2.9.3".

Version 74.0.3729.169 (Official Build) (64-bit)

Running on Ubuntu 16.04.

oom-analysis.html.gz
@etimberg
Copy link
Member

Duplicate of #7761?

@davidspencerward
Copy link
Author

davidspencerward commented Oct 13, 2020 via email •
edited

@etimberg
Copy link
Member

thanks @davidspencerward, I'll take a look and see if I can also reproduce in v3.0.0-beta.3.

@etimberg
Copy link
Member

The issue seems to be related to stepSize: 1. If I remove that, it's not a problem. I'm guessing that when stepSize is 1, there are too many ticks and we run out of memory when measuring the text.

silentmatt added a commit to silentmatt/Chart.js that referenced this issue Oct 14, 2020
@silentmatt
Fix Maximum call stack size exception in computeLabelSizes (chartjs#7881
4d4a395 
)

Calling Math.max with a large number of values was throwing an exception.
Tracking the current largest width and height as the widths and heights are
built up should be faster and avoids the exception.
@silentmatt silentmatt mentioned this issue Oct 14, 2020
Merged
@davidspencerward
Copy link
Author

davidspencerward commented Oct 14, 2020 via email

silentmatt added a commit to silentmatt/Chart.js that referenced this issue Oct 17, 2020
@silentmatt
Fix Maximum call stack size exception in _computeLabelSizes
b2c3203 
Issue chartjs#7881
@silentmatt silentmatt mentioned this issue Oct 17, 2020
Merged
@etimberg etimberg linked a pull request Oct 17, 2020 that will close this issue
Fix Maximum call stack size exception in _computeLabelSizes #7906
Merged
kurkle pushed a commit that referenced this issue Oct 18, 2020
@silentmatt
Fix Maximum call stack size exception in _computeLabelSizes (#7906)
7a35f3c 
Issue #7881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug version: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Maximum call stack size exception in _computeLabelSizes silentmatt/Chart.js
2 participants
@etimberg @davidspencerward