Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When objects are merged together, the target prototype can be polluted. #7918

Merged
merged 2 commits into from Oct 18, 2020
Merged

When objects are merged together, the target prototype can be polluted. #7918

merged 2 commits into from Oct 18, 2020

Conversation

etimberg
Copy link
Member

No description provided.

@etimberg
When objects are merged together, the target prototype can be polluted.
20e10a8 
This change blocks updates to the `__proto__` key during config merge
@etimberg etimberg merged commit dff7140 into chartjs:2.9 Oct 18, 2020
@etimberg etimberg deleted the v2-block-proto branch October 18, 2020 17:47
@simonbrunel simonbrunel mentioned this pull request Mar 9, 2021
Closed
@simonbrunel
Copy link
Member

@etimberg @kurkle I think this PR introduced a breaking change when the passed config object is not a plain object (such as reactive data in Vue.js). For example, it breaks the "Events" samples of the datalabels plugin because the listeners options object is not iterable after the merge (example).

@kurkle
Copy link
Member

kurkle commented Mar 9, 2021 •
edited

It might be actually #7404 that created the problem.

https://stackoverflow.com/questions/64878459/annotation-dont-show-in-vue-chartjs/66058308#66058308

@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request May 12, 2021
Open
GramParallelo added a commit to GramParallelo/Chart.js that referenced this pull request Mar 23, 2022
@GramParallelo
Revert "When objects are merged together, the target prototype can be…
f573324 
… polluted. (chartjs#7918)"

This reverts commit dff7140.
dracos pushed a commit to mysociety/Chart.js that referenced this pull request Sep 25, 2023
@etimberg @dracos
When objects are merged together, the target prototype can be pollute…
0c35bd2 
…d. (chartjs#7918)

* When objects are merged together, the target prototype can be polluted.

This change blocks updates to the `__proto__` key during config merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etimberg @simonbrunel @kurkle