Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation glitch #8294

Closed
kurkle opened this issue Jan 10, 2021 · 4 comments · Fixed by #8302
Closed

Animation glitch #8294

kurkle opened this issue Jan 10, 2021 · 4 comments · Fixed by #8302
Labels
type: bug

Comments

@kurkle
Copy link
Member

kurkle commented Jan 10, 2021 •
edited

While taking a look at #8293, noticed some glitches when moving the mouse around quite fast. I did a recording and here is a frame from that:

image

One very pointy point there.

https://jsfiddle.net/uo2j6cwf/

It has something to do with the radius going to 0, and I guess its the point border what is seen.
@etimberg
Copy link
Member

What browser were you using? I just tried in Firefox 84 and didn't see it. Almost seems like it'd be a problem in the canvas API itself.

@kurkle
Copy link
Member Author

kurkle commented Jan 10, 2021

Chromium based browsers (87.0.x) seem to reproduce, but not FF
I was initially using Brave.

@kurkle
Copy link
Member Author

kurkle commented Jan 10, 2021

Reproduces with pointRadius: 0.000005, but not with pointRadius: 0.00005
Easy workaround could be to set to zero when small enough.

@etimberg
Copy link
Member

yeah, that makes sense. Below 0.5 it's probably not worth drawing

@kurkle kurkle mentioned this issue Jan 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only draw points when radius >= 0.1 kurkle/Chart.js
2 participants
@etimberg @kurkle