Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tick spacing when min=0 | niceMin or max=0 #8811

Merged
merged 1 commit into from Apr 4, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Apr 4, 2021

Fix: #8806

@etimberg had already determined the points where it fails.

  • first "nice" was not skipped when it was equal to min
  • min and max were used as divisors to determine tick proximity, which obviously does not work when the value is 0
  • the spacing / 1000 => spacing / 10 is percentage to value change

@kurkle kurkle added this to the Patch 3.0.2 milestone Apr 4, 2021
@etimberg etimberg merged commit 697e3ff into chartjs:master Apr 4, 2021
kurkle added a commit to kurkle/Chart.js that referenced this pull request Apr 4, 2021
@kurkle kurkle deleted the tick-spacing branch May 30, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uneven tick spacing with maxTicksLimit and min options with Chart.js 3
2 participants