Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mirror option on x-axis #8867

Merged
merged 1 commit into from Apr 10, 2021
Merged

Support mirror option on x-axis #8867

merged 1 commit into from Apr 10, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Apr 10, 2021 •
edited

Closes #4488
Closes #4526

Bug fixed (breaking?):

  • y-axis padding in mirror mode offsets the tick label from the axis, instead of moving it over the axis.

etimberg
etimberg approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Good catch on the bug with the padding direction. That's likely existed forever

@etimberg etimberg added this to the Version 3.1 milestone Apr 10, 2021
@etimberg etimberg merged commit 7fab66c into chartjs:master Apr 10, 2021
@kurkle kurkle deleted the x-mirror branch May 30, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: bug type: enhancement
Projects
None yet
Milestone
Version 3.1
2 participants
@kurkle @etimberg