Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font: validate style, move defaults to weight #8877

Merged
merged 1 commit into from Apr 10, 2021
Merged

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Apr 10, 2021

We had a lot of style: 'bold' type defaults, which is invalid and fails when weight is also specified.

This moves the defaults to weight, and validates the style, warning and ignoring invalid values.

Resolves: #8873

@kurkle kurkle changed the title Font validate style, move defaults to weight Font: validate style, move defaults to weight Apr 10, 2021
@etimberg etimberg added this to the Version 3.1 milestone Apr 10, 2021
@kurkle
Copy link
Member Author

kurkle commented Apr 10, 2021

Filename Size Change
dist/chart.esm.js 68.8 kB -1 B (0%)
dist/chart.js 87.5 kB +114 B (0%)
dist/chart.min.js 62.3 kB +105 B (0%)
dist/chunks/helpers.segment.js 19.7 kB +115 B (+1%)

@etimberg etimberg merged commit f8885ce into chartjs:master Apr 10, 2021
@kurkle kurkle deleted the font branch May 30, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart title font doesn't change size when overriden if Chart.defaults.font is modified
2 participants