Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cartesian scale tick backdrop #8931

Merged
merged 1 commit into from Apr 18, 2021
Merged

Conversation

etimberg
Copy link
Member

Resolves #7700

@etimberg etimberg added this to the Version 3.2 milestone Apr 17, 2021
@etimberg
Copy link
Member Author

Size Change: +748 B (0%)

Total Size: 241 kB

Filename Size Change
dist/chart.esm.js 69.3 kB +277 B (0%)
dist/chart.js 88.1 kB +268 B (0%)
dist/chart.min.js 62.8 kB +203 B (0%)

Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I think we should re-consider the option names and location for v4

@kurkle kurkle merged commit af7965f into chartjs:master Apr 18, 2021
@@ -1466,6 +1511,12 @@ export default class Scale extends Element {
const item = items[i];
const tickFont = item.font;
const label = item.label;

if (item.backdrop) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this happens before label rotation, angled labels are not properly overlapped. Opening a PR for a fix soon.

@etimberg etimberg deleted the radial-scale-backdrop branch October 5, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Cartesian Scale Tick Background
3 participants