Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable the bar borderRadius at the end of the stacks #8941

Merged
merged 9 commits into from Apr 18, 2021

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Apr 18, 2021

Only shows the borderRadius of a bar when the bar is at the end of the stack.

border ends

To Do

  • Documentation
  • Tests
  • Cleanup

Resolves #8881

@etimberg etimberg added this to the Version 3.2 milestone Apr 18, 2021
src/elements/element.bar.js Outdated Show resolved Hide resolved
src/elements/element.bar.js Outdated Show resolved Hide resolved
@etimberg etimberg marked this pull request as ready for review April 18, 2021 20:04
@etimberg etimberg merged commit b92f9e5 into chartjs:master Apr 18, 2021
@einazare
Copy link

einazare commented May 5, 2021

Hey, @etimberg ,

Is there any way this functionality can be disabled so that all bars would have a border radius?
I want to achieve something like this:
Screen Shot 2021-05-05 at 11 20 23 AM
And I am almost there, but I do not know how to add radiuses on all bars :(
Screen Shot 2021-05-05 at 11 21 23 AM

Thank you,
Manu

@kurkle
Copy link
Member

kurkle commented May 5, 2021

The object syntax can be used to override this behavior.

Meaning borderRadius: {topLeft: 3, topRight: 3, bottomLeft: 3, bottomRight: 3}

@einazare
Copy link

einazare commented May 5, 2021

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacked chart bar with border radius looks strange
3 participants