Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore truncated pixels in bar width calculation #8995

Merged
merged 1 commit into from Apr 28, 2021
Merged

Ignore truncated pixels in bar width calculation #8995

merged 1 commit into from Apr 28, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Apr 28, 2021

Fixes #8994

I was not sure if the invisible data needs to be considered in some use cases, so this only ignores the truncated pixel values from the calculation.

@kurkle
Copy link
Member Author

kurkle commented Apr 28, 2021

Filename Size Change
dist/chart.esm.js 69.7 kB +32 B (0%)
dist/chart.js 88.4 kB +36 B (0%)
dist/chart.min.js 63 kB +26 B (0%)

@etimberg etimberg added this to the Version 3.2.1 milestone Apr 28, 2021
@etimberg etimberg merged commit 12bf256 into chartjs:master Apr 28, 2021
@kurkle kurkle deleted the category-zoom branch May 30, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.2.1
Development

Successfully merging this pull request may close these issues.

Category scale fails to compute proper bar width when zoomed enough
2 participants
@kurkle @etimberg