New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tick Collision #8983 too aggressive when Font Rotation is used #9025
Comments
Thanks! I have tested the change. It did not work initially. It began working when I increased my rotation from 45 to 46 degrees. |
Thanks for the heads up, I'll reopen. |
@devenbj can you provide a codepen of the situation where 46 degree rotation works and 45 does not? |
I updated the original pen: https://codepen.io/pen/?template=jOBNLBR This was tough to recreate. Let me explain how that data came to be. :) I have a time based chart. I manage the date functions in my code (more efficient than moment.js). chart.js is configured as a linear data set. I have the chart.js zoom plugin installed. I was able to synthesize the failure by zooming and captured the values. I was able to consistently reproduce the failure with the new range values and created a simplified test case. I added a "Switch" button to toggle the minRotation setting. In my production code, I have min and max set to both 46 currently, they were both set to 45. Why this is a problem: While zooming my ticks "flicker", which appears broken. Thanks... this project is awesome. The team is amazing! |
Expected Behavior
specified tick count matches the displayed tick count
Current Behavior
some ticks disappear, though there is no collision and a tick count has been specified
Possible Solution
caused by pull request #8983
Three options I thought of:
Steps to Reproduce
https://codepen.io/pen/?template=jOBNLBR
Toggle the external Chart.js script between 3.2.0 and 3.2.1
Chart should have 6 tick marks. With Chart.js 3.2.1, the 2nd and 5th are not displayed
Context
Tick marks are not consistently spaced (looking broken), and flicker when using zoom-plugin / panning
Environment
The text was updated successfully, but these errors were encountered: