Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix element reset animations in vertical line and bubble charts #9088

Merged
merged 1 commit into from May 13, 2021

Conversation

nagix
Copy link
Contributor

@nagix nagix commented May 13, 2021

This PR fixes reset animations in vertical line and bubble charts by calling getBasePixel for the value axis, not the x axis.

Version 3.2.1: https://jsfiddle.net/nagix/r80e6pn7/
Screen Shot 2021-05-13 at 11 10 40 PM

This PR: https://jsfiddle.net/nagix/nfokh29m/
Screen Shot 2021-05-13 at 11 10 40 PM 2

Fixes #9087.

@etimberg etimberg added this to the Version 3.3 milestone May 13, 2021
@etimberg etimberg merged commit 953b23b into chartjs:master May 13, 2021
@nagix nagix deleted the issue-9088 branch May 13, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element animations in a vertical chart don't use the base pixel of the value scale
3 participants