Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doughnut rotation on float edge cases #9121

Merged
merged 1 commit into from May 18, 2021
Merged

Fix doughnut rotation on float edge cases #9121

merged 1 commit into from May 18, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented May 18, 2021

Fix #9117

The error occurs because some float error:
6.283185307179585 actual circumference
6.283185307179586 2xPI

startAngle and endAngle are however equal.

@etimberg etimberg added this to the Version 3.3 milestone May 18, 2021
@etimberg etimberg merged commit a553d57 into chartjs:master May 18, 2021
@kurkle kurkle deleted the doughnut-rotation branch May 30, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.3
Development

Successfully merging this pull request may close these issues.

Doughnut appears broken when rotation equals some values. (300, 310, 320, 330, 333)
2 participants
@kurkle @etimberg