Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rtl legend text alignment #9199

Merged
merged 3 commits into from Jun 1, 2021

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented May 31, 2021

Starts fixing the RTL text alignment for legends. There was an underlying bug with textAlign: 'right' for horizontal legends. I added test coverage on that case

Resolves #9194

@etimberg etimberg marked this pull request as ready for review May 31, 2021 23:28
@etimberg etimberg added this to the Version 3.4.0 milestone May 31, 2021
@kurkle
Copy link
Member

kurkle commented Jun 1, 2021

@danielgindi does this look right to you?

@etimberg etimberg requested a review from kurkle June 1, 2021 11:54
@danielgindi
Copy link
Contributor

Looking good :)

@kurkle kurkle merged commit be01176 into chartjs:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rtl regresssions in v3
3 participants