Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

null or undefined should skip grid lines in the time scale #9252

Merged
merged 2 commits into from Jun 12, 2021
Merged

null or undefined should skip grid lines in the time scale #9252

merged 2 commits into from Jun 12, 2021

Conversation

etimberg
Copy link
Member

Resolves #9247

@etimberg etimberg added this to the Version 3.4.0 milestone Jun 11, 2021
@kurkle
Copy link
Member

kurkle commented Jun 11, 2021

Could remove the duplication by moving the skip logic to _convertTicksToLabels in core.scale.

@etimberg etimberg merged commit 9db3680 into chartjs:master Jun 12, 2021
@etimberg etimberg deleted the time-scale-skip-null branch June 12, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.4.0
Development

Successfully merging this pull request may close these issues.

Time with tick callback return null still shows grid line
2 participants
@etimberg @kurkle