Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing of the isoWeekday field #9330

Merged
merged 1 commit into from Jul 1, 2021
Merged

Fix typing of the isoWeekday field #9330

merged 1 commit into from Jul 1, 2021

Conversation

LeeLenaleee
Copy link
Collaborator

Resolves: #9329

@etimberg etimberg added this to the Version 3.4.1 milestone Jun 30, 2021
@etimberg etimberg added the type: types Typescript type changes label Jun 30, 2021
etimberg
etimberg approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I confirmed in the docs that this is already listed as boolean | number

@etimberg etimberg merged commit 760fcff into chartjs:master Jul 1, 2021
@LeeLenaleee LeeLenaleee deleted the types/isoWeekday branch September 20, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 3.4.1
Development

Successfully merging this pull request may close these issues.

Broken typing for options.scales[scaleId].time.isoWeekday
2 participants
@LeeLenaleee @etimberg