Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types with more possible events #9336

Merged
merged 1 commit into from Jul 1, 2021
Merged

Update types with more possible events #9336

merged 1 commit into from Jul 1, 2021

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Jul 1, 2021

Resolves #9335

@etimberg etimberg added the type: types Typescript type changes label Jul 1, 2021
@etimberg etimberg added this to the Version 3.4.1 milestone Jul 1, 2021
@stockiNail
Copy link
Contributor

stockiNail commented Jul 1, 2021 •
edited

@etimberg just a doubt: is the default remaining the same or all new values are anyway part of default?

@default ['mousemove', 'mouseout', 'click', 'touchstart', 'touchmove']

@etimberg
Copy link
Member Author

etimberg commented Jul 1, 2021

@stockiNail the defaults are staying the same. https://github.com/chartjs/Chart.js/blob/master/src/core/core.defaults.js#L44-L50

@stockiNail
Copy link
Contributor

@etimberg thank youuu!

@etimberg etimberg merged commit 5f58c1f into chartjs:master Jul 1, 2021
@etimberg etimberg deleted the allow-pointer-evnets branch July 1, 2021 13:37
@jmorel jmorel mentioned this pull request Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 3.4.1
Development

Successfully merging this pull request may close these issues.

Reggression in v3: pointerdown and pointerup events are missing
3 participants
@etimberg @stockiNail @kurkle