Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout: support box stacking #9364

Merged
merged 5 commits into from Jul 11, 2021
Merged

Layout: support box stacking #9364

merged 5 commits into from Jul 11, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Jul 6, 2021 •
edited

Closes #5895

image

@kurkle
Copy link
Member Author

kurkle commented Jul 6, 2021 •
edited

Filename Size Change
dist/chart.esm.js 71.7 kB +419 B (+1%)
dist/chart.js 90.8 kB +445 B (0%)
dist/chart.min.js 64.7 kB +276 B (0%)

etimberg
etimberg reviewed Jul 6, 2021
View reviewed changes
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Might be worth a sample as well

@kurkle kurkle marked this pull request as ready for review July 8, 2021 07:25
etimberg
etimberg reviewed Jul 8, 2021
View reviewed changes
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

src/core/core.layouts.js Outdated Show resolved Hide resolved
etimberg
etimberg previously approved these changes Jul 9, 2021
View reviewed changes
etimberg
etimberg previously approved these changes Jul 9, 2021
View reviewed changes
@etimberg etimberg added this to the Version 3.5.0 milestone Jul 10, 2021
@etimberg
Copy link
Member

The CI should be fixed via a rebase

@kurkle
Copy link
Member Author

kurkle commented Jul 11, 2021

rebased

@etimberg etimberg merged commit 47d4b04 into chartjs:master Jul 11, 2021
@kurkle kurkle deleted the stacked-axes branch July 11, 2021 10:35
@PavolSvidran PavolSvidran mentioned this pull request Jul 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
Version 3.5.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] Stacked up axes
2 participants
@kurkle @etimberg