Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field bounds is not defined as a property of LinearScaleOptions #9437

Closed
boreq opened this issue Jul 18, 2021 · 1 comment · Fixed by #9438
Closed

Field bounds is not defined as a property of LinearScaleOptions #9437

boreq opened this issue Jul 18, 2021 · 1 comment · Fixed by #9438
Labels
type: bug type: types Typescript type changes
Milestone

Comments

@boreq
Copy link
Contributor

boreq commented Jul 18, 2021

The documentation states that bounds is an option common to all cartesian axes. At the same time the documentation lists linear as one of the cartesian axes.

Despite this the file types/index.esm.d.ts doesn't list bounds as a field of LinearScaleOptions. It only lists it as a field of TimeScaleOptions. Attempting to set the field bounds when defining a linear scale when using TypeScript leads to a compilation error.

Perhaps this field should be defined on the type CartesianScaleOptions?

@etimberg etimberg added the type: types Typescript type changes label Jul 18, 2021
@etimberg
Copy link
Member

Good catch. I think moving the field to CartesianScaleOptions is the correct solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug type: types Typescript type changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants