New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define bounds as a field common to all cartesian axes options #9438
Conversation
This just became more confusing than I thought as the documentation lists https://www.chartjs.org/docs/latest/axes/cartesian/time.html#time-axis-specific-options I will try to look into this later. Hopefully it is just the documentation that also needs to be updated. |
The defaults are indeed different 😦 Base: https://github.com/chartjs/Chart.js/blob/master/src/core/core.scale.defaults.js#L17 |
I think the defaults should really be dirrefent for index/value scales, not to the types of scales. But that is a breaking change and should be left for v4. |
Ok maybe the right thing to do is to move the field definition to The alternative solution is to add a separate definition of that field to all types like Which one do you think is the better approach? |
I think we could have the separate definition in |
Associated with #9437.
All right that is what I did. I feel a bit weird redefining a field just to change the comment but I think specifying the default there is quite useful as people will be able to see it from their IDEs. As far as I understand there are no adverse effects of redefining a field like this. |
Associated with #9437.