Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 4.2+ compatibility #9444

Merged
merged 1 commit into from Jul 20, 2021
Merged

Typescript 4.2+ compatibility #9444

merged 1 commit into from Jul 20, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Jul 20, 2021

Fix #9328

This changes how the chart is typed in scriptable context; existing unions within are not converted to intersections.

@kurkle kurkle added type: types Typescript type changes type: bug labels Jul 20, 2021
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find on this solution. Super complicated 😅

@etimberg etimberg added this to the Version 3.5.0 milestone Jul 20, 2021
@etimberg etimberg merged commit c73add9 into chartjs:master Jul 20, 2021
@kurkle kurkle deleted the ts4.2+ branch July 20, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating bar chart data type & parsing of custom objects
2 participants