Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DomPlatform.isAttached #9448

Merged
merged 1 commit into from Jul 23, 2021
Merged

Fix DomPlatform.isAttached #9448

merged 1 commit into from Jul 23, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Jul 20, 2021 •
edited

@danielgindi
Copy link
Contributor

As Node.isConnected is not supported in most browsers yet, we could polyfill with document.body.contains(node)

@kurkle
Copy link
Member Author

kurkle commented Jul 20, 2021

To me it looks like its supported by all browsers Chart.js supports.

@danielgindi
Copy link
Contributor

Officially supporting IE11, but IE11 has no Node.isConnected

@danielgindi
Copy link
Contributor

Or did that change in 3.x?

@kurkle
Copy link
Member Author

kurkle commented Jul 20, 2021

All modern and up-to-date browsers are supported, including, but not limited to:

Chrome Edge Firefox Safari

As of version 3, we have dropped Internet Explorer 11 support.

https://www.chartjs.org/docs/latest/developers/

@etimberg etimberg added this to the Version 3.5.0 milestone Jul 22, 2021
@kurkle kurkle merged commit 0d0481d into chartjs:master Jul 23, 2021
@danielgindi danielgindi mentioned this pull request Jul 26, 2021
Closed
@kurkle kurkle deleted the is-attached branch June 29, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kurkle @danielgindi @etimberg