Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: Change context.chart to plain Chart #9477

Merged
merged 1 commit into from Jul 27, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Jul 27, 2021

Fix #9474

This is not perfect, but I guess it would satisfy most use cases. The data is available strongly typed through dataset and parsed, the raw can be casted to desired type when custom properties in data are used.

@kurkle kurkle added the type: types Typescript type changes label Jul 27, 2021
@etimberg etimberg added this to the Version 3.5.1 milestone Jul 27, 2021
@etimberg etimberg merged commit 243c970 into chartjs:master Jul 27, 2021
@kurkle kurkle deleted the context-chart branch June 29, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript problem, in ScriptableContext chart is always have type never
2 participants