Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with height and width on external plugin #9512

Closed
TearsDemon opened this issue Aug 4, 2021 · 3 comments
Closed

Problem with height and width on external plugin #9512

TearsDemon opened this issue Aug 4, 2021 · 3 comments

Comments

@TearsDemon
Copy link

Hi! I'm using chartjs-chart-boxplot for Boxplot diagram
And I noticed that height and width are using Math.abc() method (here #9208)

That completely broke the diagram cause negative value turns to the positive
Could you please explain why we should do that, and can we somehow fix that?

@etimberg
Copy link
Member

etimberg commented Aug 6, 2021

If we can find another fix for #9200 then that would work. In the boxplot, what dimensions are negative?

@LeeLenaleee
Copy link
Collaborator

Only the height is using Math.abs so instead of getting the height from the chart object you could calculate it yourself as @kurkle pointed out using the y and the base properties which should allow for negatives: https://codepen.io/kurkle/pen/YzZYRJZ

@kurkle
Copy link
Member

kurkle commented Aug 10, 2021

This issue has been fixed in chartjs-chart-boxplot v3.5

@kurkle kurkle closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants