support crossAlign on mirrored y-axis #9563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoozbuster
changed the title
kurkle
approved these changes
Aug 18, 2021
etimberg
approved these changes
Aug 18, 2021
|
Thanks for this PR and the thorough testing. 😄 |
|
Hey @etimberg - appreciate the quick review and merge! is there an ETA for the 3.5.1 patch? My team would love to pull in this fix before making our upgrade live! |
|
@snoozbuster we got 3.5.1 out just after this was merged so it's available on NPM now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9562
Linting now complains that this function has similar blocks of code and too many statements/too much complexity. I'm sure it would be possible to remove a lot of this nesting but I really don't want to be the one to try it - even with the fairly good tests surrounding this function I'm not really keen to rewrite the whole thing like that just to get this fix in.