Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable per-corner border radius in tooltip #9620

Merged
merged 1 commit into from Sep 5, 2021

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Sep 4, 2021

Resolves #9533

There are cases where this will look bad. For example:
tooltip caret gap

Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should the radius be limited to something doable?

@etimberg
Copy link
Member Author

etimberg commented Sep 5, 2021

I can look into limiting it 0.5 * width/height

Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be ideal to handle that in toTRBLCorners, so it would not need to be implemented everywhere. But I'm ok without limiting the values, until its needed for some use case.

@etimberg
Copy link
Member Author

etimberg commented Sep 5, 2021

Sure, we can add the limit later

@etimberg etimberg merged commit 0cdadd2 into chartjs:master Sep 5, 2021
@etimberg etimberg added this to the Version 3.6.0 milestone Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cornerRadius object for Tooltip (every corners)
2 participants