Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken link to cubicInterpolationMode #9626

Merged
merged 2 commits into from Sep 5, 2021
Merged

Conversation

igolskyi
Copy link
Contributor

@igolskyi igolskyi commented Sep 5, 2021

Elements -> Line configurations -> cubicInterpolationMode

Elements -> Line configurations -> cubicInterpolationMode
@@ -67,7 +67,7 @@ Namespace: `options.elements.line`, global line options: `Chart.defaults.element
| `borderDashOffset` | `number` | `0.0` | Line dash offset. See [MDN](https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/lineDashOffset).
| `borderJoinStyle` | `string` | `'miter'` | Line join style. See [MDN](https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/lineJoin).
| `capBezierPoints` | `boolean` | `true` | `true` to keep Bézier control inside the chart, `false` for no restriction.
| `cubicInterpolationMode` | `string` | `'default'` | Interpolation mode to apply. [See more...](/charts/line.md/#cubicinterpolationmode)
| `cubicInterpolationMode` | `string` | `'default'` | Interpolation mode to apply. [See more...](/charts/line.html#cubicinterpolationmode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that the extension change is required. I had a look at some of the other links in the docs and they usually use file.md#anchor so removing the / should be enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked, unfortunately not enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 are you testing with the npm run docs:dev command? That should build everything the way the CI does but give you a dev server on localhost:8080

Copy link
Contributor Author

@igolskyi igolskyi Sep 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I just checked in the browser, so you're probably right enough to remove /. Could you to close this PR, please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to push an update to just remove the slash, I can merge this 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please check is it right :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and confirmed that it works 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for good mood ;)

@etimberg etimberg merged commit eab0554 into chartjs:master Sep 5, 2021
@etimberg etimberg added this to the Version 3.6.0 milestone Sep 5, 2021
@igolskyi igolskyi deleted the patch-2 branch September 5, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants