Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove const me = this pattern #9646

Merged
merged 1 commit into from Sep 14, 2021
Merged

Remove const me = this pattern #9646

merged 1 commit into from Sep 14, 2021

Conversation

etimberg
Copy link
Member

Resolves #9645

@etimberg
Copy link
Member Author

Size Change: -1.61 kB (-1%)

Total Size: 250 kB

Filename Size Change
dist/chart.esm.js 72.1 kB -546 B (-1%)
dist/chart.js 91.4 kB -540 B (-1%)
dist/chart.min.js 64.9 kB -521 B (-1%)
ℹ️ View Unchanged
Filename Size
dist/chunks/helpers.segment.js 20.3 kB
dist/helpers.esm.js 1.18 kB

@etimberg
Copy link
Member Author

I noticed a lot of spots where destructuring assignments would have been better for size, but those should be done separately.

@etimberg etimberg added this to the Version 3.6.0 milestone Sep 14, 2021
@etimberg etimberg merged commit 8e68481 into chartjs:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
Version 3.6.0
Development

Successfully merging this pull request may close these issues.

Consider removing const me = this;
2 participants
@etimberg @kurkle