Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typings issues #9680

Merged
merged 2 commits into from Sep 24, 2021
Merged

Fix some typings issues #9680

merged 2 commits into from Sep 24, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Sep 24, 2021

Closes #9673
Closes #9670
Closes #9665

  • Update samples to return undefined instead of null to be compatible with types.

For scriptable options undefined works as "fall to next scope", so it is allowed return value from all scriptable functions.

@kurkle kurkle added the type: types Typescript type changes label Sep 24, 2021
@etimberg etimberg added this to the Version 3.6.0 milestone Sep 24, 2021
@etimberg etimberg merged commit 990a289 into chartjs:master Sep 24, 2021
@etimberg etimberg mentioned this pull request Oct 24, 2021
Closed
@kurkle kurkle deleted the type-fixes branch June 29, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 3.6.0
2 participants
@kurkle @etimberg