Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed var to const/let in the docs #9744

Merged
merged 3 commits into from Oct 13, 2021
Merged

Conversation

Prashoon123
Copy link
Contributor

In the docs, I have changed var to const/let because using var is considered a bad practice in JavaScript(when it's not needed).

@Prashoon123
Copy link
Contributor Author

@etimberg I have fixed all the issues in this PR. Kindly merge it. Thank you 🙂

@kurkle
Copy link
Member

kurkle commented Oct 11, 2021

couple of linting issues:

[lint-md] /home/runner/work/Chart.js/Chart.js/docs/samples/advanced/radial-gradient.md
[lint-md] 54:5 error 'gradient' is constant no-const-assign
[lint-md]
[lint-md] /home/runner/work/Chart.js/Chart.js/docs/samples/other-charts/multi-series-pie.md
[lint-md] 50:13 error 'datasetColors' is constant no-const-assign
[lint-md]
[lint-md] ✖ 2 problems (2 errors, 0 warnings)

@Prashoon123
Copy link
Contributor Author

@kurkle I have fixed all the linting bugs! :)

@etimberg etimberg added this to the Version 3.6.0 milestone Oct 13, 2021
@etimberg etimberg merged commit 6f7e095 into chartjs:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants